feat: change the AI command line argument to optional #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jueli12
requested review from
elliotxx,
ruquanzhao,
hai-tian,
adohe and
ffforest
as code owners
elliotxx
reviewed
Sep 24, 2024
pkg/core/handler/search/search.go
Outdated
| @@ -69,7 +67,12 @@ func SearchForResource(searchMgr *search.SearchManager, aiMgr *ai.AIManager, sea | |||
| query := searchQuery | |||
|
|
|||
| if searchPattern == storage.NLPatternType { | |||
| //logger.Info(searchQuery) | |||
| // logger.Info(searchQuery) | |||
There was a problem hiding this comment.
Useless comments can be removed
pkg/core/manager/ai/manager.go
Outdated
| @@ -25,7 +25,10 @@ type AIManager struct { | |||
|
|
|||
| // NewAIManager returns a new AIManager object | |||
| func NewAIManager(c registry.ExtraConfig) (*AIManager, error) { | |||
| aiClient := ai.NewClient(c.Backend) | |||
| if c.AIAuthToken == "" { | |||
| return nil, nil | |||
There was a problem hiding this comment.
If the token is empty, an error should be returned, otherwise the npe error is prone to occur
There was a problem hiding this comment.
When Karpor starts, it creates a new AIManager. If return the error, the startup will fail. Now I am re-evaluating whether it is null when calling the aimanager function. Is there any other way to do this?
There was a problem hiding this comment.
It should be up to the caller to decide which errors to ignore. The underlying method should ensure that the returned entity is not empty when there are no errors.
elliotxx
merged commit dbf281e
into
KusionStack:support-natural-language
3 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
change the AI command line argument to optional
Which issue(s) this PR fixes:
Fixes #551